D5749: hgweb: log error before attempting I/O

[durin42 (Augie Fackler)]

durin42 added a comment.


  In https://phab.mercurial-scm.org/D5749#84719, @mharbison72 wrote:
  
  > In https://phab.mercurial-scm.org/D5749#84640, @indygreg wrote:
  >
  > > @durin42 and I were both able to produce intermittent failures with this change. Why, I'm not sure.
  > >
  > > Does the Windows regression occur with this patch or with https://phab.mercurial-scm.org/D5751? I ask because the behavior of `socket.shutdown()` is documented to vary by platform. I wouldn't at all be surprised if https://phab.mercurial-scm.org/D5751 caused the regression seen here.
  >
  >
  > It was this patch.
  >
  > Like I said, I’ve seen connection resets in the non-daemonized serve output (don’t recall if it was push, pull, or both). I thought it was weird, but there were no other signs of problems, so I wrote it off as some odd Windows thing. (Not sure that I’ve seen it on Linux or OS X too)
  
  
  Does https://phab.mercurial-scm.org/D5764 help the situation? It made a big difference for me.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5749

To: indygreg, #hg-reviewers
Cc: durin42, mharbison72, mercurial-devel