D6394: rust-dirstate: add "dirs" rust-cpython binding
Alphare (Raphaël Gomès)
phabricator at mercurial-scm.org
Thu Jul 4 10:59:26 EDT 2019
Alphare added a comment.
In D6394#96189 <https://phab.mercurial-scm.org/D6394#96189>, @yuja wrote:
>> To my eyes, the point of `Deref` is to make the `struct` act as a "fat pointer" from the outer interface code, but maybe this does not really help that much?
> I feel DirsMultiset isn't a HashMap, but is implemented by using a HashMap.
> For example, inner.get().unwrap() returns a refcount of the path, but which
> is an implementation detail.
> So I think it's better to define methods explicitly instead of proxying
> everything to HashMap.
I see your point. I'll follow up later today.
CHANGES SINCE LAST ACTION
To: Alphare, #hg-reviewers, kevincox
Cc: yuja, durin42, kevincox, mercurial-devel
More information about the Mercurial-devel