D6567: abort: added support for graft
taapas1128 (Taapas Agrawal)
phabricator at mercurial-scm.org
Thu Jul 4 10:59:58 EDT 2019
taapas1128 added inline comments.
> pulkit wrote in commands.py:2738
> Directly calling `_abortgraft` is not safe. `graft --abort` takes wlock first and then calls it. We skipped taking the lock in case of `hg abort`.
@pulkit the wlock is activated later in `graft --abort` during cleanup. That is same in the case of `hg abort`
> pulkit wrote in test-abort.t:2
> I think we can use cases functionality in existing tests to test `hg abort`.
> I mean, in one case alias `abort` to `graft --abort` and in other case it will be the normal abort command. That will help us to prevent duplicating tests and making sure in future things work for both the cases.
I will alias this later if you want once the code for this is finalized. this is only a portion of tests taken and tests for `no-backup` and `dry-run` are added.
CHANGES SINCE LAST ACTION
To: taapas1128, #hg-reviewers
Cc: pulkit, mercurial-devel
More information about the Mercurial-devel