D6567: abort: added support for graft

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Thu Jul 4 11:00:32 EDT 2019


pulkit added inline comments.

INLINE COMMENTS

> taapas1128 wrote in commands.py:2738
> @pulkit the wlock is activated later in `graft --abort` during cleanup. That is same in the case of `hg abort`

`_dograft()` is called after taking the lock. `_abortgraft` before taking the lock does a lot of reading which should be covered with lock. Otherwise there can be a process which changes state of things between we read the data and we operate on it.

> taapas1128 wrote in test-abort.t:2
> I will alias this later if you want once the code for this is finalized. this is only a portion of tests taken and tests for `no-backup` and `dry-run` are added.

Let's start aliasing from now and have current set of patches good to go.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6567/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6567

To: taapas1128, #hg-reviewers
Cc: pulkit, mercurial-devel


More information about the Mercurial-devel mailing list