D6593: rust-minor-fixes: remove Deref in favor of explicit methods

Yuya Nishihara yuya at tcha.org
Fri Jul 5 08:50:17 EDT 2019


> +    pub fn contains_key(&self, key: &[u8]) -> bool {
> +        self.inner.contains_key(key)
> +    }
> +
> +    pub fn iter(&self) -> Iter<Vec<u8>, u32> {
> +        self.inner.iter()
> +    }

Again,

- **contains**() -> inner.contains_key()
- iter() -> inner.**keys**()

Somewhat similar to HashSet, which is basically a proxy type to
HashMap<T, ()>.

I queued this as I think it's strictly better than using Deref, but I expect
a follow up patch. Thanks.


More information about the Mercurial-devel mailing list