D6593: rust-minor-fixes: remove Deref in favor of explicit methods
Alphare (Raphaël Gomès)
phabricator at mercurial-scm.org
Fri Jul 5 09:13:07 EDT 2019
Alphare added a comment.
> Again,
>
> - **contains**() -> inner.contains_key()
> - iter() -> inner.**keys**()
>
> Somewhat similar to HashSet, which is basically a proxy type to
> HashMap<T, ()>.
`contains()` is my bad, I forgot.
Using `keys()` will change the behavior, as I actually need to expose an `Iter<Vec<u8>, u32>`. Is your issue with the naming?
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6593/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6593
To: Alphare, #hg-reviewers
Cc: yuja, durin42, kevincox, mercurial-devel
More information about the Mercurial-devel
mailing list