D6568: abort: added support for rebase
pulkit (Pulkit Goyal)
phabricator at mercurial-scm.org
Fri Jul 5 17:57:07 EDT 2019
pulkit added inline comments.
INLINE COMMENTS
> rebase.py:1926
>
> +def hgabortrebase(ui, repo, **opts):
> + if opts.get('no_backup'):
we can name this function abortrebase, no need to add hg in front.
> rebase.py:1928
> + if opts.get('no_backup'):
> + raise error.Abort(_("rebase does not support no-backup flag"))
> + if opts.get('dry_run'):
`aborting rebase ..`
> test-rebase-abort.t:128
> + $ hg abort --dry-run
> + aborting rebase
> +
This message means that we are aborting rebase. Rather we should print something like, `rebase in progress, will be aborted`.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6568/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6568
To: taapas1128, martinvonz, #hg-reviewers
Cc: pulkit, mercurial-devel
More information about the Mercurial-devel
mailing list