D6594: RFC dirstatemap

Pierre-Yves David pierre-yves.david at ens-lyon.org
Mon Jul 8 10:06:20 EDT 2019


On 7/7/19 3:45 PM, Yuya Nishihara wrote:
>> sharing references between Rust and Python:
>> https://raphaelgomes.dev/blog/articles/2019-07-01-sharing-references-between-python-and-rust.html.
> 
> Do you have some benchmark number compared to simpler (and dumb) approaches
> such as caching PyList/Dict representation?
> 
> I heard boxing a PyObject has measurable cost, so we might even want to keep
> the entire data backed by PyObjects depending on how frequently the data will
> be exposed to Python world.
> 
> (I don't have expertise to comment on the soundness of the proposed ref handling
> business, and this patch is too big for me to review, sorry.)

One facet of this also simply to have an actual case where we share ref. 
There will be other area where we needs them (eg: revset, revlog, …). So 
battle testing the principle in a simple case is useful. To me, this is 
a good enough reason to go this way. Working around it will only be 
temporary.

Cheers,

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list