D6616: extdata: avoid crashing inside subprocess when we get a revset parse error

Yuya Nishihara yuya at tcha.org
Tue Jul 9 20:17:04 EDT 2019


>          if proc:
> -            proc.communicate()
> +            try:
> +                proc.communicate()
> +            except ValueError:
> +                # This happens if we started iterating src and then
> +                # get a parse error on a line. It should be safe to ignore.
> +                pass

No idea what to do, but maybe the process would be still running if
ValueError occurred.


More information about the Mercurial-devel mailing list