D6616: extdata: avoid crashing inside subprocess when we get a revset parse error

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Tue Jul 9 20:18:23 EDT 2019


yuja added a comment.


  >   if proc:
  >
  > - proc.communicate()
  >
  > +            try:
  > +                proc.communicate()
  > +            except ValueError:
  > +                # This happens if we started iterating src and then
  > +                # get a parse error on a line. It should be safe to ignore.
  > +                pass
  
  No idea what to do, but maybe the process would be still running if
  ValueError occurred.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6616/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6616

To: durin42, #hg-reviewers, pulkit
Cc: yuja, mjpieters, mercurial-devel


More information about the Mercurial-devel mailing list