D6594: RFC dirstatemap

[kevincox (Kevin Cox)]

kevincox added a comment.


  In D6594#96518 <https://phab.mercurial-scm.org/D6594#96518>, @yuja wrote:
  
  > Yes, so we'll probably want to minimize the data exchanged between Rust
  > and Python. This means we'll eventually move more logic to Rust side, which
  > hopefully reduce the number of elements to be exposed through the iterator
  > interface. Until then, it might be better to move iterator-heavy objects
  > to CPython/PyO3 layer. Just my guess.
  
  This is likely true. But I suspect we don't need to worry too much unless performance is shown to be an issue. Then it makes sense to make spot-optimizations.
  
  Especially if there are plans to move more code into Rust over time it will be very easy to spend a lot of time optimizing the interface only to find that the interface has moved a layer up in 4 months.

INLINE COMMENTS

> dirstate_map.rs:275
> +        let parents;
> +        if file_contents.len() == 40 {
> +            parents = DirstateParents {

Give this magic number a name?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6594/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6594

To: Alphare, #hg-reviewers
Cc: yuja, durin42, kevincox, mjpieters, mercurial-devel