D6611: blackbox: disable extremely verbose logging (issue6110)

valentin.gatienbaron (Valentin Gatien-Baron) phabricator at mercurial-scm.org
Wed Jul 10 18:21:26 EDT 2019


valentin.gatienbaron added inline comments.
valentin.gatienbaron marked an inline comment as done.

INLINE COMMENTS

> durin42 wrote in blackbox.py:97
> Let's make this configurable, and this is the default. Maybe blackbox.ignore, with a default of the things you've specified?

I made the ignore list configurable, although it seems to be of limited utility: you can replace the default, but extending seems like the more useful thing to do. Extending the list requires repeating the default, and the default may not be particularly stable across versions.

I changed the priority of tracked and ignored, so tracked takes predecence. This means that `tracked = *, cmdserver` would log cmdserver events, as that seems a bit better to me and maybe that's why you wanted the configurability.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6611/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6611

To: valentin.gatienbaron, #hg-reviewers
Cc: durin42, mercurial-devel


More information about the Mercurial-devel mailing list