D6629: rust-dirstate: use EntryState enum instead of literals
Alphare (Raphaël Gomès)
phabricator at mercurial-scm.org
Wed Jul 17 06:29:52 EDT 2019
Alphare added inline comments.
INLINE COMMENTS
> kevincox wrote in lib.rs:85
> I like using `{!r}` so that the substituted entry is quoted and unambiguous.
Did you mean `{:?}`. I can't find anything related to your syntax.
> kevincox wrote in parsers.rs:42
> If you are going to a comment I would say why. However in this case it probably isn't worth having a comment.
>
> You can also do this on one line `entry.state.into::<u8>() as c_char` which I think is simple enough.
The one-liner does not compile, so I improved the comment to explain why (which it really should have in the first place).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6629/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6629
To: Alphare, #hg-reviewers, kevincox
Cc: durin42, kevincox, mercurial-devel
More information about the Mercurial-devel
mailing list