D6651: rust-utils: remove buggy assertion

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Thu Jul 18 09:45:04 EDT 2019


yuja added a comment.


  >   While this assertion had good intentions, it broke existing behavior with a
  >   nasty panic.
  
  So the hgignore parser doesn't handle `\#` correctly?
  
  https://www.mercurial-scm.org/repo/hg-committed/file/5672bb73f61e/rust/hg-core/src/filepatterns.rs#l251

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6651/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6651

To: Alphare, #hg-reviewers
Cc: yuja, durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list