D6682: fsmonitor: add support for extra `hg debuginstall` data

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Wed Jul 24 05:22:50 EDT 2019


This revision is now accepted and ready to land.
pulkit added inline comments.
pulkit accepted this revision.

INLINE COMMENTS

> __init__.py:182
> +               ui.configpath("fsmonitor", "watchman_exe"))
> +    import tempfile
> +    root = tempfile.mkdtemp()

Moved this import to top level in flight.

> __init__.py:191
> +    except watchmanclient.Unavailable as e:
> +        err = str(e)
> +    fm.condwrite(err, "fsmonitor-watchman-error",

This might make py3 unhappy.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6682/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6682

To: durin42, #hg-reviewers, pulkit
Cc: pulkit, mjpieters, mercurial-devel


More information about the Mercurial-devel mailing list