D6693: fix: ignore fixer tool configurations that are missing patterns
hooper (Danny Hooper)
phabricator at mercurial-scm.org
Thu Jul 25 21:01:41 EDT 2019
hooper added inline comments.
> martinvonz wrote in fix.py:738-739
> Is this change needed given the change above?
It makes this function more robust. It might be called by someone who actually tries to use a Fixer with no pattern.
> martinvonz wrote in test-fix.t:1280
> nit: The `--debug` seems unnecessary, unless we want to make sure that we *don't* get any output.
Yes, it will show a "subprocess: ...." line if we go ahead and use the fixer. The file also exists to make it possible to observe that kind of regression.
Keep in mind the fix command has no output until you set up hooks or something.
CHANGES SINCE LAST ACTION
To: hooper, #hg-reviewers
Cc: martinvonz, mercurial-devel
More information about the Mercurial-devel