D6436: narrow: use narrow_widen wireproto command to widen in case of ellipses
rdamazio (Rodrigo Damazio Bovendorp)
phabricator at mercurial-scm.org
Tue Jun 4 19:27:39 EDT 2019
rdamazio added a comment.
Hopefully not too late
INLINE COMMENTS
> pulkit wrote in narrowcommands.py:306
> I believe it streams rather than downloading the whole bundle into memory. `getbundle()` uses the same function and I think we do streaming there. https://www.mercurial-scm.org/repo/hg-committed/file/127937874395/mercurial/exchange.py#l1757
>
> I also asked @marmoute and he also think that it does streaming.
The difference from the code you're pointing too is that you're calling .result() here, which blocks until the results are fully streamed in (see httppeer.py) - so I really think this is NOT streaming.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6436
To: pulkit, durin42, martinvonz, #hg-reviewers
Cc: marmoute, rdamazio, mercurial-devel
More information about the Mercurial-devel
mailing list