D6389: rust-dirstate: create dirstate submodule

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Thu Jun 6 11:26:42 EDT 2019


martinvonz added inline comments.

INLINE COMMENTS

> kevincox wrote in mod.rs:7
> Ok, I'm still not convinced this is the best API to expose but if it is a public API I guess it can't be changed.

> Ok, I'm still not convinced this is the best API to expose but if it is a public API I guess it can't be changed.

@kevincox, I haven't followed the discussion here and I don't know much about rust. I'll queue this patch based on your review. If you had any more comments, those can be addressed in a follow-up patch.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6389

To: Alphare, #hg-reviewers, kevincox
Cc: martinvonz, durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list