D6494: statecheck: added support for the statecheck.unfinishedstates

taapas1128 (Taapas Agrawal) phabricator at mercurial-scm.org
Sat Jun 8 11:24:30 EDT 2019


taapas1128 requested review of this revision.
taapas1128 added a comment.


  @martinvonz  Doing that would be kind of difficult because these changes are not due to refactoring but due to `statecheck.hint()` which is a unified function for generating hint messages. If I change the messages in accordance to `cmdutil.unfinishedstates` then this problem will be there in the in integration of `STATES`. If you still want it I can do that by removing `statecheck.hint()` completely and getting the messages from `cmdutil.py`. So should I do that ?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6494

To: taapas1128, durin42, martinvonz, #hg-reviewers
Cc: mjpieters, Kwan, mercurial-devel


More information about the Mercurial-devel mailing list