D6487: states: created new class to handle multi-step unfinished states

[martinvonz (Martin von Zweigbergk)]

martinvonz added a comment.


  In https://phab.mercurial-scm.org/D6487#94407, @taapas1128 wrote:
  
  > Splitting them into exactly those steps would not have been possible
  
  
  Why not? The current form is better than before, but I would like to know why my suggestion is not possible. My suggested step 1 is surely possible.

INLINE COMMENTS

> cmdutil.py:3301
> -# note: bisect is intentionally excluded
> -# (state file, clearable, allowcommit, error, hint)
> -unfinishedstates = [

Since bisect was intentionally excluded before this patch, it's probably best to add it in a separate patch. That way you get a place (i.e. the commit message) to explain why it was excluded before and why it should no longer be excluded.

> state.py:104
> +        fname is the file name in which data should be stored in .hg directory.
> +        It is None for merge command.
> +        clearable boolean determines whether or not interrupted states can be

Why?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6487

To: taapas1128, #hg-reviewers, martinvonz, durin42
Cc: mjpieters, Kwan, martinvonz, pulkit, mercurial-devel