D6502: state: moved cmdutil.STATES and utilities to state.py

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Sat Jun 8 18:15:22 EDT 2019


martinvonz added inline comments.

INLINE COMMENTS

> state.py:126
>              msg = (_("use 'hg %s --continue' or 'hg %s --abort'") %
> -            (self.cmdname,self.cmdname))
> +            (self.cmdname, self.cmdname))
>          return msg

Nit: This should be moved to the patch that introduced the bad formatting.

> state.py:185
> +
> +def _commentlines(raw):
> +    '''Surround lineswith a comment char and a new line'''

This feels a lot like morestatus functionality and should perhaps have been left in cmdutil.py.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6502

To: taapas1128, #hg-reviewers
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list