D6429: rust-discovery: avoid useless calls to addcommons/addmissings

kevincox (Kevin Cox) phabricator at mercurial-scm.org
Mon Jun 10 12:53:54 UTC 2019


kevincox requested changes to this revision.
kevincox added a comment.
This revision now requires changes to proceed.


  Wouldn't it be better to make `add_missing_revisions` work properly on empty inputs? It seems like it is too error prone to try and catch every caller. If possible I would like to push this check down as far as possible.
  
  It seems easy enough to do in https://www.mercurial-scm.org/repo/hg/file/tip/rust/hg-core/src/discovery.rs#l56 by checking if `common` grew.  This has the added benefit that attempting to re-add bases will also skill the work.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6429

To: gracinet, #hg-reviewers, kevincox
Cc: durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list