D6428: rust-discovery: using the children cache in add_missing
kevincox (Kevin Cox)
phabricator at mercurial-scm.org
Mon Jun 10 12:59:46 UTC 2019
kevincox accepted this revision.
kevincox added inline comments.
INLINE COMMENTS
> discovery.rs:233
> + /// sets, for which the discovery process will engage into sampling
> + /// that needs the children cache anyway.
> pub fn add_missing_revisions(
These added comments seem more relevant to the implementation of the method than they are to the caller. Would it make sense to move them inside of the function body so that they don't busy the doc-comment?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6428
To: gracinet, #hg-reviewers, kevincox
Cc: durin42, kevincox, mercurial-devel
More information about the Mercurial-devel
mailing list