D6503: statecheck: added support for STATES

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Mon Jun 10 09:44:54 EDT 2019


pulkit added inline comments.

INLINE COMMENTS

> state.py:147
>  
>      def isunfinished(self, repo, mergecheck=False):
> +        """determines whether a multi-step operation is in progress

This change should be a part of patch where isunfinished was introduced.

> state.py:158
>  unfinishedstates=[]
> -unfinishedstates.append(statecheck('graft','graftstate', clearable=True,
> -                                    allowcommit=False))
> +unfinishedstates.append(statecheck('graft', 'graftstate', clearable=True,
> +                                   allowcommit=False))

This adding of space should also be a part of patch where this line was introduced.

> state.py:167
>                                      allowcommit=False))
> +unfinishedstates.append(statecheck('merge', 'None', clearable=False,
> +                                    allowcommit=False, specialhint=

merge can be cleared using `hg update` and hence clearable should be `True`

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6503

To: taapas1128, durin42, #hg-reviewers
Cc: pulkit, mercurial-devel


More information about the Mercurial-devel mailing list