D6503: statecheck: added support for STATES

taapas1128 (Taapas Agrawal) phabricator at mercurial-scm.org
Tue Jun 11 04:21:56 EDT 2019


taapas1128 added a subscriber: martinvonz.
taapas1128 added inline comments.

INLINE COMMENTS

> pulkit wrote in state.py:186
> the previous patch moves all this code, and this patch just removes it mostly. I think we can prevent the code-movement then.

Yes but this is according to the splitting @martinvonz suggested. The same thing happens between https://phab.mercurial-scm.org/D6484 and https://phab.mercurial-scm.org/D6501. Actually this is done for the benefit of the reviewer so he/she can see how the code changed (here `_getrepostate()` function.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6503

To: taapas1128, durin42, #hg-reviewers
Cc: martinvonz, pulkit, mercurial-devel


More information about the Mercurial-devel mailing list