D6508: py3: use .startswith() instead of bytes[0]
pulkit (Pulkit Goyal)
phabricator at mercurial-scm.org
Tue Jun 11 12:51:05 UTC 2019
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Doing bytes[0] will return the ascii value of that position which breaks
comparison with a bytechar.
This makes test-absorb.t work again on py3.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6508
AFFECTED FILES
hgext/absorb.py
CHANGE DETAILS
diff --git a/hgext/absorb.py b/hgext/absorb.py
--- a/hgext/absorb.py
+++ b/hgext/absorb.py
@@ -871,7 +871,7 @@
patchlines = mdiff.splitnewlines(buf.getvalue())
# hunk.prettystr() will update hunk.removed
a2 = a1 + hunk.removed
- blines = [l[1:] for l in patchlines[1:] if l[0] != '-']
+ blines = [l[1:] for l in patchlines[1:] if not l.startswith('-')]
return path, (a1, a2, blines)
def overlaydiffcontext(ctx, chunks):
To: pulkit, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list