D6429: rust-discovery: optimization of add commons/missings for empty arguments

[gracinet (Georges Racinet)]

gracinet added a comment.


  In D6429#94512 <https://phab.mercurial-scm.org/D6429#94512>, @kevincox wrote:
  
  > Wouldn't it be better to make `add_missing_revisions` work properly on empty inputs? It seems like it is too error prone to try and catch every caller. If possible I would like to push this check down as far as possible.
  > It seems easy enough to do in https://www.mercurial-scm.org/repo/hg/file/tip/rust/hg-core/src/discovery.rs#l56 by checking if `common` grew.  This has the added benefit that attempting to re-add bases will also skill the work.
  
  Done in the update version.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6429/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6429

To: gracinet, #hg-reviewers, kevincox
Cc: durin42, kevincox, mercurial-devel