D6501: state: created new class statecheck to handle unfinishedstates

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Fri Jun 14 18:48:16 EDT 2019


pulkit added inline comments.

INLINE COMMENTS

> state.py:141
> +# A list of statecheck objects for multistep operations like graft.
> +unfinishedstates = []
> +def addunfinished(**cmddata):

add a new line after this.

> state.py:142
> +unfinishedstates = []
> +def addunfinished(**cmddata):
> +    """this accepts a dict having command data, makes a statecheck object and

we can accept cmddata here as dict, no need for `**`. They can be removed from callers of it's function too. Only use when we pass that to statecheck.__init__()

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6501/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6501

To: taapas1128, durin42, martinvonz, #hg-reviewers
Cc: pulkit, mjpieters, mercurial-devel


More information about the Mercurial-devel mailing list