D6430: rust-discovery: using from Python code
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Mon Jun 17 01:04:18 EDT 2019
martinvonz added a comment.
> This example is not a goal in itself,
Hmm, I would actually consider that the strongest selling point of this series. The other case (the 6.8% improvement) doesn't seem enough to justify all this code.
> but it showcases several different
> areas in which the process can become slow, due to different factors, and
> how this full Rust version can help.
I don't see this as much of an argument for discovery in Rust. I only care about practically measurable differences. The only real improvement was that "pull into mozilla-try repo from mozilla-unified" case.
I'm fine with taking this series if we think that that use case is important enough to justify the extra maintenance of having a second implementation of the discovery code. I wouldn't think that use case is very common, but I'm guessing that the fact that you spent time on this series means that you have customers with repos with similar characteristics.
What do others think?
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6430/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6430
To: gracinet, #hg-reviewers
Cc: martinvonz, mercurial-devel
More information about the Mercurial-devel
mailing list