D6503: statecheck: added support for STATES

taapas1128 (Taapas Agrawal) phabricator at mercurial-scm.org
Mon Jun 17 03:30:55 EDT 2019


taapas1128 added inline comments.

INLINE COMMENTS

> martinvonz wrote in state.py:154
> Why does bisect have to be treated differently?

This was suggested by @pulkit to keep bisect last too.

> martinvonz wrote in test-strip.t:276
> This doesn't seem right. Did you forget to update this patch after your other patch got landed?

yes I haven't updated this diff since that patch because as I said on irc I wanted inclusion of merge in `checkunfinished()` as seperate patch because :

1. This would require cleanup of existing code which was detecting merge in various operations.
2. The operations would lose there personalized messages I dont want them to be lost and develop a method in which registered message can be changed accordingly.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6503/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6503

To: taapas1128, durin42, #hg-reviewers, martinvonz
Cc: mjpieters, martinvonz, pulkit, mercurial-devel


More information about the Mercurial-devel mailing list