D6501: state: created new class statecheck to handle unfinishedstates
taapas1128 (Taapas Agrawal)
phabricator at mercurial-scm.org
Mon Jun 17 03:38:32 EDT 2019
taapas1128 added inline comments.
INLINE COMMENTS
> martinvonz wrote in state.py:142
> I think it would be simpler to make `addunfinished()` take four arguments instead of a dict. That's what we usually do. @pulkit, what do you think? Is there are reason to pass a single dict here?
there are not just 4 arguments but arguments for personazed messages too. Also this method has been made simin=lar to the registration method of `registrar` which also takes a dict.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6501/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6501
To: taapas1128, durin42, martinvonz, #hg-reviewers
Cc: pulkit, mjpieters, mercurial-devel
More information about the Mercurial-devel
mailing list