D6503: statecheck: added support for STATES

Mon Jun 17 12:40:28 EDT 2019

martinvonz added inline comments.

INLINE COMMENTS

> taapas1128 wrote in state.py:154
> This was suggested by @pulkit to keep bisect last too.

@pulkit, can you explain why bisect needs to be last?

> taapas1128 wrote in test-graft.t:281
> In D6504 <https://phab.mercurial-scm.org/D6504> is not the message method alright?

We generally (always?) use a short lowercase message for the hint. I'm not sure we want to change that. OTOH, I also don't want to make the morestatus (`hg status -v`) output inconsistent like this patch does. I suppose we could have a discussion about changing the style we use in our hints. You could send a message to mercurial-devel@ if you want to do that. It might be easier for you to avoid changing the style and let each operation have a message ("X in progress"), a hint ("use X to continue ..."), and another message for morestatus ("To continue: ...").

> taapas1128 wrote in test-strip.t:276
> yes I haven't updated this diff since that patch because as I said on irc I wanted inclusion of merge in `checkunfinished()` as seperate patch because :
> 
> 1. This would require cleanup of existing code which was detecting merge in various operations.
> 2. The operations would lose there personalized messages I dont want them to be lost and develop a method in which registered message can be changed accordingly.

I really don't want to have an intermediate patch affect test cases like this. So I guess I'm suggesting that you fix the existing code first then, although I don't know what cases those are.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6503/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6503

To: taapas1128, durin42, #hg-reviewers, martinvonz
Cc: mjpieters, martinvonz, pulkit, mercurial-devel