D6501: state: created new class statecheck to handle unfinishedstates
pulkit (Pulkit Goyal)
phabricator at mercurial-scm.org
Mon Jun 17 16:09:51 EDT 2019
pulkit added inline comments.
INLINE COMMENTS
> martinvonz wrote in state.py:142
> I think it would be simpler to make `addunfinished()` take four arguments instead of a dict. That's what we usually do. @pulkit, what do you think? Is there are reason to pass a single dict here?
> I think it would be simpler to make addunfinished() take four arguments instead of a dict. That's what we usually do. @pulkit, what do you
> think? Is there are reason to pass a single dict here?
I agree that passing four arguments will be better than a dict. I didn't realize that before reading your latest comment.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6501/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6501
To: taapas1128, durin42, martinvonz, #hg-reviewers
Cc: Kwan, pulkit, mjpieters, mercurial-devel
More information about the Mercurial-devel
mailing list