D6501: state: created new class statecheck to handle unfinishedstates

[av6 (Anton Shestakov)]

av6 added inline comments.

INLINE COMMENTS

> state.py:151
> +    'graft',
> +    fname = 'graftstate',
> +    clearable = True,

It's funny how Pulkit's comment is now at this line and looks like asking to add spaces around `=` here. But in this case `=` is not an operator, it's used to indicate keyword arguments. We don't want spaces around it (similarly to PEP8).

Bad:

  addunfinished(
      'graft',
      fname = 'graftstate',
      clearable = True,
      allowcommit = False,
      cmdhint = _("use 'hg graft --continue' or 'hg graft --stop' to stop")
  )

Good:

  addunfinished(
      'graft',
      fname='graftstate',
      clearable=True,
      allowcommit=False,
      cmdhint=_("use 'hg graft --continue' or 'hg graft --stop' to stop")
  )

Even better (as long as it fits into 79 characters per line):

  addunfinished(
      'graft', 'graftstate', clearable=True, allowcommit=False,
      cmdhint=_("use 'hg graft --continue' or 'hg graft --stop' to stop")
  )

There's a lot of places where this needs to be fixed in this series, not just here.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6501/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6501

To: taapas1128, durin42, martinvonz, #hg-reviewers
Cc: av6, Kwan, pulkit, mjpieters, mercurial-devel