D6501: state: created new class statecheck to handle unfinishedstates

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Tue Jun 18 07:16:24 EDT 2019


pulkit added inline comments.

INLINE COMMENTS

> phabricator.py:53
>  from mercurial import (
> -    cmdutil,
>      context,

unrelated change?

> rebase.py:1953
>      cmdutil.summaryhooks.add('rebase', summaryhook)
> -    statemod.unfinishedstates.append(
> -        ['rebasestate', False, False, _('rebase in progress'),
> -         _("use 'hg rebase --continue' or 'hg rebase --abort'")])
> +    statemod.addunfinished('rebase',fname='rebasestate')
>      cmdutil.afterresolvedstates.append(

need a space after `,`.

> strip.py:11
>      bookmarks as bookmarksmod,
> -    cmdutil,
>      error,

unrelated change?

> state.py:94
> +       histedit, bisect, update etc and check whether such commands
> +       are in an unfinished conditition of not and return appropriate message
> +       and hint.

s/of/or (unfinished condition or not)

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6501/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6501

To: taapas1128, durin42, martinvonz, #hg-reviewers
Cc: av6, Kwan, pulkit, mjpieters, mercurial-devel


More information about the Mercurial-devel mailing list