D6537: procutil: allow callers of runbgcommand to assume the process starts
durin42 (Augie Fackler)
phabricator at mercurial-scm.org
Tue Jun 18 13:44:34 UTC 2019
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Experimentally starting the subprocess can take as much as 40ms, and
for some of our use cases that's frivolous: we know the binary will
start, and if it doesn't we'd only ever ignore it and continue
anyway. This lets those use cases be faster.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6537
AFFECTED FILES
mercurial/utils/procutil.py
CHANGE DETAILS
diff --git a/mercurial/utils/procutil.py b/mercurial/utils/procutil.py
--- a/mercurial/utils/procutil.py
+++ b/mercurial/utils/procutil.py
@@ -470,7 +470,8 @@
# See https://phab.mercurial-scm.org/D1701 for discussion
_creationflags = DETACHED_PROCESS | subprocess.CREATE_NEW_PROCESS_GROUP
- def runbgcommand(script, env, shell=False, stdout=None, stderr=None):
+ def runbgcommand(
+ script, env, shell=False, stdout=None, stderr=None, ensurestart=True):
'''Spawn a command without waiting for it to finish.'''
# we can't use close_fds *and* redirect stdin. I'm not sure that we
# need to because the detached process has no console connection.
@@ -480,12 +481,15 @@
creationflags=_creationflags, stdout=stdout,
stderr=stderr)
else:
- def runbgcommand(cmd, env, shell=False, stdout=None, stderr=None):
+ def runbgcommand(
+ cmd, env, shell=False, stdout=None, stderr=None, ensurestart=True):
'''Spawn a command without waiting for it to finish.'''
# double-fork to completely detach from the parent process
# based on http://code.activestate.com/recipes/278731
pid = os.fork()
if pid:
+ if not ensurestart:
+ return
# Parent process
(_pid, status) = os.waitpid(pid, 0)
if os.WIFEXITED(status):
To: durin42, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list