D6490: commit: add --force flag to close branch from a non-head changeset

mharbison72 (Matt Harbison) phabricator at mercurial-scm.org
Tue Jun 18 09:44:57 EDT 2019


mharbison72 added a comment.


  In D6490#95305 <https://phab.mercurial-scm.org/D6490#95305>, @pulkit wrote:
  
  > I think adding a `--force` flag to `hg commit` is not a nice option. force can mean a lot of things and here except in closing the non-head changeset, it is no-op. 
  > For example, I am in middle of a rebase, tried to commit, it says rebase in progress. I see there is a --force flag, I try to use that to force the commit.
  > We can do one of the following:
  >
  > 1. maybe a more specific flag name like `--allow-close-branch` or something like that
  > 2. a config option instead of a flag name
  
  Fair point.  Specific is better.
  
  I'd suggest `--force-close-branch` as a standalone flag (i.e. you don't need to also use `--close-branch`; it wasn't clear to me if that's what you meant).  `--allow-close-branch` and `--close-branch` don't seem different enough to remember the difference.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6490/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6490

To: khanchi97, #hg-reviewers, mharbison72
Cc: pulkit, mharbison72, mercurial-devel


More information about the Mercurial-devel mailing list