D6503: statecheck: added support for STATES

taapas1128 (Taapas Agrawal) phabricator at mercurial-scm.org
Tue Jun 18 12:42:29 EDT 2019


taapas1128 added inline comments.
taapas1128 marked 3 inline comments as done.

INLINE COMMENTS

> martinvonz wrote in state.py:215
> I can see that `getrepostate()` is unchanged, but I cannot see that `checkunfinished()` is unchanged (line 187 includes `'bisect'` in the version I'm looking at). `clearunfinished()` also seems to handle bisect specially. I still think my suggested `reportonly` flag is the best option we have.

the special handling is given so that `checkunfinished()` and `clearunfinished()` bypass `bisect` completely.(see line 93 D6501 <https://phab.mercurial-scm.org/D6501> the comment above unfinishedstates)  And reportonly flag is not required because for `morestatus`  uses `getrepostate()` which is itself a report only feature.

> martinvonz wrote in test-graft.t:282
> This should use the multi-line style

that is done in D6504 <https://phab.mercurial-scm.org/D6504>. Do you want me to fold that here?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6503/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6503

To: taapas1128, durin42, #hg-reviewers, martinvonz
Cc: mjpieters, martinvonz, pulkit, mercurial-devel


More information about the Mercurial-devel mailing list