D6562: filemerge: make last line of prompts <40 english chars (issue6158)
spectral (Kyle Lippincott)
phabricator at mercurial-scm.org
Mon Jun 24 19:30:52 EDT 2019
spectral added a comment.
In D6562#95775 <https://phab.mercurial-scm.org/D6562#95775>, @durin42 wrote:
> I like this, but could I get you to add a patch 3 that introduces a develwarn for this?
Done, and it found a couple other cases, but I'm not sure I like it (D6573 <https://phab.mercurial-scm.org/D6573>) - non-English users might not be able to enable the devel warnings without getting a bunch of spam. I believe by the time we get to `ui.prompt()` we've already done the `_()` translation and it's in the target language? Do we have any idea if anyone enables developer warnings outside of tests (which would typically be written in English, at least for core).
Unfortunately, I don't think it's something we could put in check-style.py either... we won't know that these are going to a prompt. Anyway, we can continue discussion on this on D6573 <https://phab.mercurial-scm.org/D6573>.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6562/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6562
To: spectral, #hg-reviewers
Cc: durin42, mercurial-devel
More information about the Mercurial-devel
mailing list