D6393: rust-dirstate: add "dirs" Rust implementation

Alphare (Raphaël Gomès) phabricator at mercurial-scm.org
Thu Jun 27 09:17:16 EDT 2019


Alphare added a comment.


  In D6393#95768 <https://phab.mercurial-scm.org/D6393#95768>, @kevincox wrote:
  
  > Sorry. I was busy. In general don't worry about blocking on me, I can't promise any sort of reasonable response time. Worst case I can review the changes after submission and changes can be made afterwards.
  
  Sure, no problem, thanks.
  I've also sneaked some `&[u8]` instead of `Vec<u8>` in my last update.

INLINE COMMENTS

> kevincox wrote in dirs_multiset.rs:43
> You can replate the nested if with:
> 
>   if skip_state == Some(state) {

Unless I'm missing something, this would render the `if` statement useless.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6393/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6393

To: Alphare, #hg-reviewers, kevincox
Cc: martinvonz, durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list