D6553: shelve: move shelve extension to core

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Fri Jun 28 12:31:11 EDT 2019


martinvonz added inline comments.

INLINE COMMENTS

> shelve.py:296-304
> +# duplicate of rebase.clearstatus to avoid importing rebase
> +def clearstatus(repo):
> +    'Remove the status files'
> +    # Make sure the active transaction won't write the state file
> +    tr = repo.currenttransaction()
> +    if tr:
> +        tr.removefilegenerator('rebasestate')

This doesn't seem right. It seems D3693 <https://phab.mercurial-scm.org/D3693> just forgot to delete `clearstatus()`. Could you send a patch before this one to do that?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6553/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6553

To: navaneeth.suresh, #hg-reviewers, pulkit
Cc: martinvonz, pulkit, Kwan, mjpieters, mercurial-devel


More information about the Mercurial-devel mailing list