D6042: py3: convert filtername to str if it's None

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Fri Mar 1 20:36:08 EST 2019


yuja added a comment.


  > +        filtername = repo.filtername
  >  +        if filtername is None:
  >  +            filtername = 'None'
  > 
  >   repo.ui.log('branchcache', 'updated %s branch cache in %.4f seconds\n',
  > 
  > - repo.filtername, duration) +                    filtername, duration)
  
  Perhaps, we can use %r instead. It's just logging, we wouldn't care the output
  format. Or simply, `repo.filtername or b'None'`.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6042

To: pulkit, #hg-reviewers
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list