D5940: uncommit: make experimental.uncommitondirtydir to work on PATH (issue5977)

[navaneeth.suresh (Navaneeth Suresh)]

navaneeth.suresh marked 5 inline comments as done.
navaneeth.suresh added a comment.


  In https://phab.mercurial-scm.org/D5940#88065, @martinvonz wrote:
  
  > I don't understand the commit message. `experimental.uncommitondirtydir` already works with PATH, doesn't it? I think you mean something like "uncommit: allow dirty working copy with PATH". Did I understand that right?
  
  
  If PATH is given, `experimental.uncommitondirtydir` is ignored. This is the current scenario. I thought the current commit message would go well. But, yours sound sweet to me. Do you want me to replace that?

INLINE COMMENTS

> martinvonz wrote in test-uncommit.t:421
> I still don't think it's a good idea to recommend an experimental config option

I was going with Yuya's and Pulkit's suggestions. Fixing an existing bug without modifying the current UI sounds reasonable to me. I too agree that recommending an experimental config option quite often is not a good idea. But, we don't want to remove that config option either as you (and Google) are already using that. I'll wait for @pulkit and you. If you are having a strong opinion on this, then I won't do that.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5940

To: navaneeth.suresh, #hg-reviewers
Cc: martinvonz, pulkit, mercurial-devel