D6052: global: use raw string for setlocale() argument

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Sun Mar 3 11:54:32 EST 2019


indygreg added a comment.


  Yeah, `''.join([u''])` will coerce the `str` to `unicode`, so we're fine on that front. The problem is only with `HGUNICODEPEDANTRY=1`, which will raise during implicit `str` <-> `unicode` coercion.
  
  One can reproduce a failure with `HGUNICODEPEDANTRY=1 ./run-tests.py -l test-record.t`.
  
  I doubt the test suite has been remotely close to passing with `HGUNICODEPEDANTRY` for possibly years. I'm not sure it is even worth keeping around, since Python 3 has very similar functionality for free. I dunno.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6052

To: indygreg, durin42, #hg-reviewers
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list