D5940: uncommit: make experimental.uncommitondirtydir to work on PATH (issue5977)

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Sun Mar 3 16:04:21 EST 2019

pulkit added a comment.

  In https://phab.mercurial-scm.org/D5940#88065, @martinvonz wrote:
  > I don't understand the commit message. `experimental.uncommitondirtydir` already works with PATH, doesn't it? I think you mean something like "uncommit: allow dirty working copy with PATH". Did I understand that right?
  Right now, if PATH is given, we always allow to uncommit. This patch now looks good to me. I will wait about what you think before pushing it.


> navaneeth.suresh wrote in test-uncommit.t:421
> I was going with Yuya's and Pulkit's suggestions. Fixing an existing bug without modifying the current UI sounds reasonable to me. I too agree that recommending an experimental config option quite often is not a good idea. But, we don't want to remove that config option either as you (and Google) are already using that. I'll wait for @pulkit and you. If you are having a strong opinion on this, then I won't do that.

Once this patch gets in, can you send a follow-up which adds the new flag and suggest that?

  rHG Mercurial


To: navaneeth.suresh, #hg-reviewers
Cc: martinvonz, pulkit, mercurial-devel

More information about the Mercurial-devel mailing list