D5940: uncommit: make experimental.uncommitondirtydir to work on PATH (issue5977)
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Sun Mar 3 16:34:16 EST 2019
martinvonz added a comment.
In https://phab.mercurial-scm.org/D5940#88276, @pulkit wrote:
> In https://phab.mercurial-scm.org/D5940#88065, @martinvonz wrote:
> > I don't understand the commit message. `experimental.uncommitondirtydir` already works with PATH, doesn't it? I think you mean something like "uncommit: allow dirty working copy with PATH". Did I understand that right?
> Right now, if PATH is given, we always allow to uncommit. This patch now looks good to me. I will wait about what you think before pushing it.
Sure, but the commit message makes it sound like we're changing behavior when experimental.uncommitondirtydir is set, which is not correct.
> pulkit wrote in test-uncommit.t:421
> Once this patch gets in, can you send a follow-up which adds the new flag and suggest that?
Ideally that patch would come first (so we don't have to remember to roll back this patch if that other patch doesn't come before we cut the next release).
To: navaneeth.suresh, #hg-reviewers
Cc: martinvonz, pulkit, mercurial-devel
More information about the Mercurial-devel