D6044: phabricator: convert conduit response JSON unicode to bytes inside callconduit
Kwan (Ian Moody)
phabricator at mercurial-scm.org
Mon Mar 4 12:12:40 EST 2019
Kwan added a comment.
In https://phab.mercurial-scm.org/D6044#88262, @yuja wrote:
> > - parsed = json.loads(body) + parsed = pycompat.rapply(lambda x: encoding.unitolocal(x) + if isinstance(x, unicode) else x, json.loads(body))
> Perhaps some of `r''` would have to be changed to `b''` since dict keys
> are now byte strings. See the wiki page for our Py3 hacks.
Ah, good point, thanks. Would it be worth keeping the keys as r'' strings? rapply can fairly easily be extended with an optional notkeys boolean that would allow doing so.
To: Kwan, #hg-reviewers
Cc: yuja, mercurial-devel
More information about the Mercurial-devel