D6038: push: added clear warning message when pushing a closed branch(issue6080)

[pulkit (Pulkit Goyal)]

pulkit added inline comments.

INLINE COMMENTS

> discovery.py:351
> +        raise error.Abort(_("push creates new remote branches:"
> +                            " %s (closed)!")% branchnames,
>                           hint=_("use 'hg push --new-branch' to create"

This is adding ` (closed)` unconditionally even if the branch we are pushing is open.

> test-push-warn.t:256
>    searching for changes
> -  abort: push creates new remote branches: c, d!
> +  abort: push creates new remote branches: c, d (closed)!
>    (use 'hg push --new-branch' to create new remote branches)

Here none of the branch `c` and `d` are closed, but it still appends `(closed)`.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6038

To: taapas1128, #hg-reviewers
Cc: pulkit, mharbison72, mercurial-devel