D6026: lock: Improve the waiting for lock message which will help newcomers(issue6081)

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Wed Mar 6 08:40:46 EST 2019


pulkit added a comment.


  I am not sure the new message is much helpful. As JordiGH and others pointed out on IRC, it will definitely be helpful if we can show which operation has the lock right now.
  
  Something like:
  
  `waiting for lock on working directory of b held by process '*' running <cmd-name> on host '*'`

INLINE COMMENTS

> test-extdiff.t:155
> +  diffing */extdiff.*/a.46c0e4daeb72/b a.81906f2b98ac/b (glob)
>    diffing */extdiff.*/a.46c0e4daeb72/a a.81906f2b98ac/a (glob)
>    making snapshot of 2 files from rev 46c0e4daeb72

unrelated changes.

> pulkit wrote in test-lock-badness.t:18
> unrelated changes in the test file here and below.

still here are unrealted changes.

> test-lock-badness.t:62
>    waiting for lock on working directory of b held by process '*' on host '*' (glob)
> +  Another Mercurial process seems to be running in
> +                       this repository, e.g. an editor opened by 'hg commit'.

The output is not correctly aligned.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6026

To: akshjain.jain74, #hg-reviewers
Cc: pulkit, mercurial-devel


More information about the Mercurial-devel mailing list