[PATCH 14 of 18 "] verify: rename the `checklog` to `_checkrevlog`

Pierre-Yves David pierre-yves.david at ens-lyon.org
Wed Mar 6 11:29:30 EST 2019


# HG changeset patch
# User Pierre-Yves David <pierre-yves.david at octobus.net>
# Date 1551878119 -3600
#      Wed Mar 06 14:15:19 2019 +0100
# Node ID 1acdc1069618867d7b3e0add9a435fad2810ab64
# Parent  4390cbb4a01be93907ec49c5dce2599fe5a272df
# EXP-Topic verify
# Available At https://bitbucket.org/octobus/mercurial-devel/
#              hg pull https://bitbucket.org/octobus/mercurial-devel/ -r 1acdc1069618
verify: rename the `checklog` to `_checkrevlog`

The method is for internal use only. In addition we make the method name
explicitly contains `revlog` to make it clearer it is checking higher level
revlog properties.

diff --git a/mercurial/verify.py b/mercurial/verify.py
--- a/mercurial/verify.py
+++ b/mercurial/verify.py
@@ -76,7 +76,7 @@ class verifier(object):
             fmsg = pycompat.byterepr(inst)
         self._err(linkrev, "%s: %s" % (msg, fmsg), filename)
 
-    def checklog(self, obj, name, linkrev):
+    def _checkrevlog(self, obj, name, linkrev):
         """verify high level property of a revlog
 
         - revlog is present,
@@ -207,7 +207,7 @@ class verifier(object):
         mflinkrevs = {}
         filelinkrevs = {}
         seen = {}
-        self.checklog(cl, "changelog", 0)
+        self._checkrevlog(cl, "changelog", 0)
         progress = ui.makeprogress(_('checking'), unit=_('changesets'),
                                    total=len(repo))
         for i in repo:
@@ -253,7 +253,7 @@ class verifier(object):
         if self.refersmf:
             # Do not check manifest if there are only changelog entries with
             # null manifests.
-            self.checklog(mf, label, 0)
+            self._checkrevlog(mf, label, 0)
         progress = ui.makeprogress(_('checking'), unit=_('manifests'),
                                    total=len(mf))
         for i in mf:


More information about the Mercurial-devel mailing list